Grails 3 and default layout

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Grails 3 and default layout

Ronny Løvtangen
Hi,

Grails’ default sitemesh layout (main.gsp) is based on HTML5 Boilerplate (https://html5boilerplate.com/) which just recently released v5.0.0.
One of the things they did in v5.0.0 was to drop IE6/IE7 hacks and get rid of the conditional comments, which had some serious issues, making more harm than good (https://github.com/h5bp/html5-boilerplate/issues/1187)
The same issues applies to Grails, and I have been bitten by this at my current customer, which had their domain on Microsofts compatibility view list.

Grails 3 would be a good opportunity to align with the new HTML5 Boilerplate.
Any objections to this? If not I will create a few jira issues and corresponding pull requests.

Best Regards
Ronny Løvtangen

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/D76B1CBA-EF88-435F-B587-16D687107AFD%40lovtangen.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Grails 3 and default layout

Graeme Rocher-2
+1 Pull request welcome 

On Sunday, February 15, 2015, Ronny Løvtangen <[hidden email]> wrote:
Hi,

Grails’ default sitemesh layout (main.gsp) is based on HTML5 Boilerplate (https://html5boilerplate.com/) which just recently released v5.0.0.
One of the things they did in v5.0.0 was to drop IE6/IE7 hacks and get rid of the conditional comments, which had some serious issues, making more harm than good (https://github.com/h5bp/html5-boilerplate/issues/1187)
The same issues applies to Grails, and I have been bitten by this at my current customer, which had their domain on Microsofts compatibility view list.

Grails 3 would be a good opportunity to align with the new HTML5 Boilerplate.
Any objections to this? If not I will create a few jira issues and corresponding pull requests.

Best Regards
Ronny Løvtangen

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:_e(%7B%7D,&#39;cvml&#39;,&#39;grails-dev-discuss%2Bunsubscribe@googlegroups.com&#39;);" target="_blank">grails-dev-discuss+unsubscribe@....
To post to this group, send email to <a href="javascript:_e(%7B%7D,&#39;cvml&#39;,&#39;grails-dev-discuss@googlegroups.com&#39;);" target="_blank">grails-dev-discuss@....
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/D76B1CBA-EF88-435F-B587-16D687107AFD%40lovtangen.com.
For more options, visit https://groups.google.com/d/optout.


--
Graeme Rocher

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/CAO_wNoe2Gxb8HBwfrgXWJHG%3D_9Xu9_R0i1XWFnAPj9kM7rsbvA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Grails 3 and default layout

Ronny Løvtangen
Great!

I just need a little guidance, as things have changed.
Previously, the skeleton where located under <grails-core>/grails-resources, e.g. the main layout was <grails-core>/grails-resources/src/grails/grails-app/views/layouts/main.gsp
After poking around a little, I found out that these are now moved to a separate repo on GitHub: https://github.com/grails/grails-profile-repository
And that this repo is synced to ~/.grails/repository
The repo URL and local path is mentioned in the class org.grails.cli.profile.git.GitProfileRepository.

I forked https://github.com/grails/grails-profile-repository. Any tips for how to best test my changes to this fork with my development build of grails-core master? Should I symlink ~/.grails/repository to my fork of grails-profile-repository? Or change paths in GitProfileRepository? Or is there a better way?


Also; should changes to https://github.com/grails/grails-profile-repository go in the regular Jira project, https://jira.grails.org/browse/GRAILS  or is there a separate Jira project?


Best Regards,
Ronny

On 15 Feb 2015, at 14:12, Graeme Rocher <[hidden email]> wrote:

+1 Pull request welcome 

On Sunday, February 15, 2015, Ronny Løvtangen <[hidden email]> wrote:
Hi,

Grails’ default sitemesh layout (main.gsp) is based on HTML5 Boilerplate (https://html5boilerplate.com/) which just recently released v5.0.0.
One of the things they did in v5.0.0 was to drop IE6/IE7 hacks and get rid of the conditional comments, which had some serious issues, making more harm than good (https://github.com/h5bp/html5-boilerplate/issues/1187)
The same issues applies to Grails, and I have been bitten by this at my current customer, which had their domain on Microsofts compatibility view list.

Grails 3 would be a good opportunity to align with the new HTML5 Boilerplate.
Any objections to this? If not I will create a few jira issues and corresponding pull requests.

Best Regards
Ronny Løvtangen

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:_e(%7B%7D,'cvml','grails-dev-discuss%2Bunsubscribe@googlegroups.com');" target="_blank" class="">grails-dev-discuss+unsubscribe@....
To post to this group, send email to <a href="javascript:_e(%7B%7D,'cvml','grails-dev-discuss@googlegroups.com');" target="_blank" class="">grails-dev-discuss@....
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/D76B1CBA-EF88-435F-B587-16D687107AFD%40lovtangen.com.
For more options, visit https://groups.google.com/d/optout.


--
Graeme Rocher


--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/CAO_wNoe2Gxb8HBwfrgXWJHG%3D_9Xu9_R0i1XWFnAPj9kM7rsbvA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/966E8EB2-EE06-4A6C-93B8-872EDA8822CF%40lovtangen.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Grails 3 and default layout

Ronny Løvtangen
Thanks for merging the PR, Graeme.

I ended up symlinking ~/.grails/repository to my locally cloned grails-profile-repository during development. Worked fine, I could then run ‘grails create-app foo’ and verify that the generated app was as expected.


Ronny

On 16 Feb 2015, at 22:08, Ronny Løvtangen <[hidden email]> wrote:

Great!

I just need a little guidance, as things have changed.
Previously, the skeleton where located under <grails-core>/grails-resources, e.g. the main layout was <grails-core>/grails-resources/src/grails/grails-app/views/layouts/main.gsp
After poking around a little, I found out that these are now moved to a separate repo on GitHub: https://github.com/grails/grails-profile-repository
And that this repo is synced to ~/.grails/repository
The repo URL and local path is mentioned in the class org.grails.cli.profile.git.GitProfileRepository.

I forked https://github.com/grails/grails-profile-repository. Any tips for how to best test my changes to this fork with my development build of grails-core master? Should I symlink ~/.grails/repository to my fork of grails-profile-repository? Or change paths in GitProfileRepository? Or is there a better way?


Also; should changes to https://github.com/grails/grails-profile-repository go in the regular Jira project, https://jira.grails.org/browse/GRAILS  or is there a separate Jira project?


Best Regards,
Ronny

On 15 Feb 2015, at 14:12, Graeme Rocher <[hidden email]> wrote:

+1 Pull request welcome 

On Sunday, February 15, 2015, Ronny Løvtangen <[hidden email]> wrote:
Hi,

Grails’ default sitemesh layout (main.gsp) is based on HTML5 Boilerplate (https://html5boilerplate.com/) which just recently released v5.0.0.
One of the things they did in v5.0.0 was to drop IE6/IE7 hacks and get rid of the conditional comments, which had some serious issues, making more harm than good (https://github.com/h5bp/html5-boilerplate/issues/1187)
The same issues applies to Grails, and I have been bitten by this at my current customer, which had their domain on Microsofts compatibility view list.

Grails 3 would be a good opportunity to align with the new HTML5 Boilerplate.
Any objections to this? If not I will create a few jira issues and corresponding pull requests.

Best Regards
Ronny Løvtangen

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:_e(%7B%7D,'cvml','grails-dev-discuss%2Bunsubscribe@googlegroups.com');" target="_blank" class="">grails-dev-discuss+unsubscribe@....
To post to this group, send email to <a href="javascript:_e(%7B%7D,'cvml','grails-dev-discuss@googlegroups.com');" target="_blank" class="">grails-dev-discuss@....
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/D76B1CBA-EF88-435F-B587-16D687107AFD%40lovtangen.com.
For more options, visit https://groups.google.com/d/optout.


--
Graeme Rocher


--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/CAO_wNoe2Gxb8HBwfrgXWJHG%3D_9Xu9_R0i1XWFnAPj9kM7rsbvA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/02B0EBA2-F24A-48FA-9D23-06B650711988%40lovtangen.com.
For more options, visit https://groups.google.com/d/optout.