Quantcast

Mail Plugin Pull Request

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Mail Plugin Pull Request

Nathan Wells
Hello,

I've got a pull request on the mail plugin:


It fixes two issues with the mail plugin, which are tracked in JIRA:

http://jira.grails.org/browse/GPMAIL-60 - The fix for this was a one-line change to initialize some variables. It has a unit test, to verify the fix.
http://jira.grails.org/browse/GPMAIL-61 - This is, again, a one-line change to avoid a StackOverflowError because of some bad, but forgivable meta-programming usage. I have tested this in my environment, but can't figure out a good way to test it in the general case.

Can these be merged in and a new version released by the end of next week? I have a site going production soon and I want to make sure my app depends as little as possible on "unsanctioned" code.

Nathan Wells
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Mail Plugin Pull Request

Nathan Wells
Thanks Graeme for merging the pull! Any guess on the timeline for a new release? I'm a little ignorant to the process here.

Nathan Wells


On Thu, Jun 21, 2012 at 9:07 PM, Nathan Wells <[hidden email]> wrote:
Hello,

I've got a pull request on the mail plugin:


It fixes two issues with the mail plugin, which are tracked in JIRA:

http://jira.grails.org/browse/GPMAIL-60 - The fix for this was a one-line change to initialize some variables. It has a unit test, to verify the fix.
http://jira.grails.org/browse/GPMAIL-61 - This is, again, a one-line change to avoid a StackOverflowError because of some bad, but forgivable meta-programming usage. I have tested this in my environment, but can't figure out a good way to test it in the general case.

Can these be merged in and a new version released by the end of next week? I have a site going production soon and I want to make sure my app depends as little as possible on "unsanctioned" code.

Nathan Wells

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Mail Plugin Pull Request

Graeme Rocher-4
Administrator
Will look to do a new release shortly

Cheers

On Fri, Jun 22, 2012 at 6:58 PM, Nathan Wells <[hidden email]> wrote:

> Thanks Graeme for merging the pull! Any guess on the timeline for a new
> release? I'm a little ignorant to the process here.
>
> Nathan Wells
>
>
>
> On Thu, Jun 21, 2012 at 9:07 PM, Nathan Wells <[hidden email]> wrote:
>>
>> Hello,
>>
>> I've got a pull request on the mail plugin:
>>
>> https://github.com/gpc/grails-mail/pull/11
>>
>> It fixes two issues with the mail plugin, which are tracked in JIRA:
>>
>> http://jira.grails.org/browse/GPMAIL-60 - The fix for this was a one-line
>> change to initialize some variables. It has a unit test, to verify the fix.
>> http://jira.grails.org/browse/GPMAIL-61 - This is, again, a one-line
>> change to avoid a StackOverflowError because of some bad, but forgivable
>> meta-programming usage. I have tested this in my environment, but can't
>> figure out a good way to test it in the general case.
>>
>> Can these be merged in and a new version released by the end of next week?
>> I have a site going production soon and I want to make sure my app depends
>> as little as possible on "unsanctioned" code.
>>
>> Nathan Wells
>
>



--
Graeme Rocher
Grails Project Lead
SpringSource - A Division of VMware
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Mail Plugin Pull Request

Nathan Wells
Thanks for the update!

Nathan Wells


On Wed, Jun 27, 2012 at 1:04 AM, Graeme Rocher <[hidden email]> wrote:
Will look to do a new release shortly

Cheers

On Fri, Jun 22, 2012 at 6:58 PM, Nathan Wells <[hidden email]> wrote:
> Thanks Graeme for merging the pull! Any guess on the timeline for a new
> release? I'm a little ignorant to the process here.
>
> Nathan Wells
>
>
>
> On Thu, Jun 21, 2012 at 9:07 PM, Nathan Wells <[hidden email]> wrote:
>>
>> Hello,
>>
>> I've got a pull request on the mail plugin:
>>
>> https://github.com/gpc/grails-mail/pull/11
>>
>> It fixes two issues with the mail plugin, which are tracked in JIRA:
>>
>> http://jira.grails.org/browse/GPMAIL-60 - The fix for this was a one-line
>> change to initialize some variables. It has a unit test, to verify the fix.
>> http://jira.grails.org/browse/GPMAIL-61 - This is, again, a one-line
>> change to avoid a StackOverflowError because of some bad, but forgivable
>> meta-programming usage. I have tested this in my environment, but can't
>> figure out a good way to test it in the general case.
>>
>> Can these be merged in and a new version released by the end of next week?
>> I have a site going production soon and I want to make sure my app depends
>> as little as possible on "unsanctioned" code.
>>
>> Nathan Wells
>
>



--
Graeme Rocher
Grails Project Lead
SpringSource - A Division of VMware
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email



Loading...