New Plugin - grails address

[James Cook-15]

Hi,

Would like to add a new plugin to the repo.

https://github.com/jamescookie/grails-address

It's fairly simply domain object that contains address information,
but this is something that I have had to define over and over again in
many projects and it will speed up development.

Not sure if I can just publish this as I am an existing author, but my
grails.org username is james.cookie

James

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Eamonn O'Connell-2]

IMHO, there doesn't seem to be enough functionality/benefit there to
warrant it being a public plugin.

On 25 May 2012 10:23, James Cook <[hidden email]> wrote:

> Hi,
>
> Would like to add a new plugin to the repo.
>
> https://github.com/jamescookie/grails-address
>
> It's fairly simply domain object that contains address information,
> but this is something that I have had to define over and over again in
> many projects and it will speed up development.
>
> Not sure if I can just publish this as I am an existing author, but my
> grails.org username is james.cookie
>
> James
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Nick Vaidyanathan]

This is one of those strange things that everybody seems to end up defining multiple times (like a Person, an Order, etc etc) yet every definition seems somewhat different. Some implementations may not like 3 lines for an address (putting it all in 1 string called street), or the town, county, country fields...

I wouldn't see any harm in allowing it. It's fairly flexible. It would be nice to begin coming up with community standard domain models for things like this (like Spring Security pretty much established the baseline Person domain)

I see you used the constraints plugin. Clever. 

The display and render field parts of the TagLib are nicely separated.  Though you may want to add another attribute called as with a default value of "list", and have another method that builds the markup as an html list and returns that string. You could write out that string result instead of writing directly to the output stream. 

This would enable you later to add something like an "hCard" attribute and write addresses in a microformat way, in case you want to be one of those cool pandas they tell us about in the movies. 

You may also want to i18n if (!address || !(address instanceof Address)) throw new IllegalArgumentException("Need to supply an address")

On Fri, May 25, 2012 at 2:01 AM, Eamonn O'Connell <[hidden email]> wrote:

IMHO, there doesn't seem to be enough functionality/benefit there to
warrant it being a public plugin.

On 25 May 2012 10:23, James Cook <[hidden email]> wrote:
> Hi,
>
> Would like to add a new plugin to the repo.
>
> https://github.com/jamescookie/grails-address
>
> It's fairly simply domain object that contains address information,
> but this is something that I have had to define over and over again in
> many projects and it will speed up development.
>
> Not sure if I can just publish this as I am an existing author, but my
> grails.org username is james.cookie
>
> James
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email

[James Cook-15]

Is that a yes or a no then?

On 25 May 2012 09:23, James Cook <[hidden email]> wrote:

> Hi,
>
> Would like to add a new plugin to the repo.
>
> https://github.com/jamescookie/grails-address
>
> It's fairly simply domain object that contains address information,
> but this is something that I have had to define over and over again in
> many projects and it will speed up development.
>
> Not sure if I can just publish this as I am an existing author, but my
> grails.org username is james.cookie
>
> James

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[pledbrook]

Hi James,

> Is that a yes or a no then?

Sorry for keeping you hanging on this one. A couple of suggestions:

* please add an example of the output from the GSP tag to the docs
* update the documentation URL in the plugin descriptor (unless you
plan to add the docs to the portal page)
* perhaps add a method for generating a comma-separated string of the address.

Thanks,

Peter

--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[James Cook]

Hi,

I have made those changes.

Regards
James

On 7 June 2012 11:12, Peter Ledbrook <[hidden email]> wrote:

> Hi James,
>
>> Is that a yes or a no then?
>
> Sorry for keeping you hanging on this one. A couple of suggestions:
>
> * please add an example of the output from the GSP tag to the docs
> * update the documentation URL in the plugin descriptor (unless you
> plan to add the docs to the portal page)
> * perhaps add a method for generating a comma-separated string of the address.
>
> Thanks,
>
> Peter
>
> --
> Peter Ledbrook
> Grails Advocate
> SpringSource - A Division of VMware
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[pledbrook]

> I have made those changes.

Thanks for that. I hope you don't hate me for this, but I have one
more suggestion: please add @attr groovydoc tags to the taglib so that
the IDEs can provide auto-completion. The basic form is

    @attr <attrName> [REQUIRED] <description>

where REQUIRED is optional. Check out the Spring Security Core taglib
for examples:

    https://github.com/grails-plugins/grails-spring-security-core/blob/master/grails-app/taglib/grails/plugins/springsecurity/SecurityTagLib.groovy

That's definitely my last request before approval! And again, sorry
for the delay. It's been a busy few weeks.

Peter

--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[James Cook]

Done :)

On 11 June 2012 11:33, Peter Ledbrook <[hidden email]> wrote:

>> I have made those changes.
>
> Thanks for that. I hope you don't hate me for this, but I have one
> more suggestion: please add @attr groovydoc tags to the taglib so that
> the IDEs can provide auto-completion. The basic form is
>
>    @attr <attrName> [REQUIRED] <description>
>
> where REQUIRED is optional. Check out the Spring Security Core taglib
> for examples:
>
>    https://github.com/grails-plugins/grails-spring-security-core/blob/master/grails-app/taglib/grails/plugins/springsecurity/SecurityTagLib.groovy
>
> That's definitely my last request before approval! And again, sorry
> for the delay. It's been a busy few weeks.
>
> Peter
>
> --
> Peter Ledbrook
> Grails Advocate
> SpringSource - A Division of VMware
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[pledbrook]

> Done :)

Cool. You should now be able to publish the plugin.

Thanks for the contribution,

Peter

--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[pledbrook]

>> Done :)
>
> Cool. You should now be able to publish the plugin.

I was looking through the logs and it seems the portal update failed.
Can you try

    grails publish-plugin --ping-only

?

Thanks,

Peter

--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[James Cook]

Seems to have worked:

C:\Dev\grails-address>grails publish-plugin --ping-only
| Plugin packaged grails-grails-address-0.1.zip
| Plugin packaged grails-grails-address-0.1.zip
| POM generated: C:\Dev\grails-address\target/pom.xml
WARN: No SCM provider installed.
Publishing to Grails Central
Notifying plugin portal 'http://grails.org/plugin/grails-address' of release...
Notification successful

But nothing under: http://grails.org/plugin/grails-address as yet?

James

On 12 June 2012 09:01, Peter Ledbrook <[hidden email]> wrote:

>>> Done :)
>>
>> Cool. You should now be able to publish the plugin.
>
> I was looking through the logs and it seems the portal update failed.
> Can you try
>
>    grails publish-plugin --ping-only
>
> ?
>
> Thanks,
>
> Peter
>
> --
> Peter Ledbrook
> Grails Advocate
> SpringSource - A Division of VMware
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Eamonn O'Connell-2]

Looks like it is here James:

http://grails.org/plugin/address

On 12 June 2012 13:58, James Cook <[hidden email]> wrote:

> Seems to have worked:
>
> C:\Dev\grails-address>grails publish-plugin --ping-only
> | Plugin packaged grails-grails-address-0.1.zip
> | Plugin packaged grails-grails-address-0.1.zip
> | POM generated: C:\Dev\grails-address\target/pom.xml
> WARN: No SCM provider installed.
> Publishing to Grails Central
> Notifying plugin portal 'http://grails.org/plugin/grails-address' of release...
> Notification successful
>
> But nothing under: http://grails.org/plugin/grails-address as yet?
>
> James
>
> On 12 June 2012 09:01, Peter Ledbrook <[hidden email]> wrote:
>>>> Done :)
>>>
>>> Cool. You should now be able to publish the plugin.
>>
>> I was looking through the logs and it seems the portal update failed.
>> Can you try
>>
>>    grails publish-plugin --ping-only
>>
>> ?
>>
>> Thanks,
>>
>> Peter
>>
>> --
>> Peter Ledbrook
>> Grails Advocate
>> SpringSource - A Division of VMware
>>
>> ---------------------------------------------------------------------
>> To unsubscribe from this list, please visit:
>>
>>    http://xircles.codehaus.org/manage_email
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[pledbrook]

> C:\Dev\grails-address>grails publish-plugin --ping-only
> | Plugin packaged grails-grails-address-0.1.zip
> | Plugin packaged grails-grails-address-0.1.zip
> | POM generated: C:\Dev\grails-address\target/pom.xml
> WARN: No SCM provider installed.
> Publishing to Grails Central
> Notifying plugin portal 'http://grails.org/plugin/grails-address' of release...
> Notification successful
>
> But nothing under: http://grails.org/plugin/grails-address as yet?

FYI I'm pretty sure I've fixed the issue that was causing problems
with the original 'grails-address' publication.

Peter

--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[jroenberg]

Eamonn O'Connell-2 wrote

IMHO, there doesn't seem to be enough functionality/benefit there to
warrant it being a public plugin.

I agree with this statement.
I would think that it should implement some/most of the standardized address formats as specified by Universal Postal Union:
http://www.upu.int/nc/en/activities/addressing/postal-addressing-systems-in-member-countries.html

What do you think James ?