Hi Jon + Peter,
I've updated the documentation and renamed the newrelic-api.jar to include the version number in there.
regards,
CP
________________________________________
From: Lim, C.P. [
[hidden email]]
Sent: Thursday, August 02, 2012 8:54 AM
To:
[hidden email]
Subject: RE: [grails-dev] New Relic Grails plugin
Hi,
Thanks for the feedback.
Peter - I'm planning on putting some basic information on the plugins page and then add a link for more information to the github page. I can also put in some more detailed information on running NewRelic with run-app - thanks for the idea!
Jon - I can definitely version the JAR in the lib directory, but am uncomfortable with publishing someone else's JAR in the Maven Repo. As far as I'm aware NewRelic don't manage a Maven repo, and they provide the api jar as part of their installation.
If I make these changes, is it ok for me to publish this plugin?
regards,
CP
________________________________________
From: Jon Palmer [
[hidden email]]
Sent: Wednesday, August 01, 2012 10:35 PM
To:
[hidden email]
Subject: RE: [grails-dev] New Relic Grails plugin
You probably also want to include the dependency on the newRelic-api.jar that comes bundled in the lib directory and that jar should be versioned. I would be nice if you didn't even have to include the jar in the lib directory and could just link to a Maven repo that had the jar available to be pulled in.
Regards,
Jon
-----Original Message-----
From:
[hidden email] [mailto:
[hidden email]] On Behalf Of Peter Ledbrook
Sent: Wednesday, August 01, 2012 5:18 AM
To:
[hidden email]
Subject: Re: [grails-dev] New Relic Grails plugin
> I would like to be able to publish the Grails New Relic plugin to the
> Grails repository.
>
> Username: cplim
> plugin name: grails-newrelic-plugin
> source:
https://github.com/Sensis/grails-newrelic-pluginThanks for the contribution, looks good. Just a couple of points:
1. I recommend updating the 'documentation' property on the plugin descriptor to point at the README on GitHub. Unless you plan to replicate and maintain the docs on grails.org.
2. Would it be possible to add an explanation of how to set up New Relic for run-app and run-war? Perhaps the plugin could provide that as an option? I don't know whether that's feasible or not as I don't know New Relic well enough.
Regards,
Peter
--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_emailThis email is intended for the person(s) to whom it is addressed and may contain information that is PRIVILEGED or CONFIDENTIAL. Any unauthorized use, distribution, copying, or disclosure by any person other than the addressee(s) is strictly prohibited. If you have received this email in error, please notify the sender immediately by return email and delete the message and any attachments from your system.
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
Locked
