Looking at that pull-request merging the plugins (or just Jeff
accepting your pull request and publishing) seems the right course of
action. Open-source can move slowly. Hopefully he is on this mailing
list, and this thread will highlight the issue.
Eamonn
On 15 June 2012 19:19, Gavin Hogan <
[hidden email]> wrote:
> WRT 2 and 3 I will fix those, thanks for pointing them out.
>
> I also do not think that there needs to be two plugins, I had reached out to
> Jeff Ellis and had a pull request that went unanswered after about a month.
>
https://github.com/jeffellis/grails-yammer-metrics/pull/2/>
> Please advise
>
> Gavin
>
>
>
>
>
>
> On Fri, Jun 15, 2012 at 12:13 PM, Peter Ledbrook <
[hidden email]>
> wrote:
>>
>> > Hi I have created a plugin which aims to simplify the usage of the coda
>> > hale/yammer java metrics project
>> > [
http://metrics.codahale.com/getting-started/ ].
>> >
>> > I have created two ast driven annotations and plan to develop more.
>> >
>> > My grails.org username is gavinhogan
>> > My code is at
https://github.com/gavinhogan/grails-metrics>> > The plugin name is 'metrics'
>>
>> A few questions and recommendations:
>>
>> 1. Why not incorporate the annotations into the yammer-metrics plugin?
>> I don't understand why there should be two separate plugins.
>> 2. 'documentation' and 'scm' properties in the plugin descriptor need
>> updating (and uncommenting in the latter case).
>> 3. The README needs to be reviewed. There are a few typo/grammar
>> errors in there that could do with fixing.
>>
>> Regards,
>>
>> Peter
>>
>> --
>> Peter Ledbrook
>> Grails Advocate
>> SpringSource - A Division of VMware
>>
>> ---------------------------------------------------------------------
>> To unsubscribe from this list, please visit:
>>
>>
http://xircles.codehaus.org/manage_email>>
>>
>
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
Locked
