|
We've run into a problem with grails-ldap-server - we're guessing it's
down to order of ServletContextHolder bean initialisation and the afterPropertiesSet method getting called. The fix is trivial: Index: plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy =================================================================== --- plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy (revision 2546) +++ plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy (working copy) @@ -1,5 +1,7 @@ package grails.ldap.server +import javax.servlet.ServletContext + import org.apache.directory.server.core.DefaultDirectoryService import org.apache.directory.server.ldap.LdapService import org.apache.directory.server.protocol.shared.SocketAcceptor @@ -11,24 +13,26 @@ import org.apache.directory.shared.ldap.exception.LdapNameNotFoundException import org.springframework.web.util.WebUtils -import org.codehaus.groovy.grails.web.context.ServletContextHolder import org.springframework.beans.factory.InitializingBean import org.springframework.beans.factory.DisposableBean import org.springframework.beans.factory.BeanNameAware +import org.springframework.web.context.ServletContextAware + import grails.util.BuildSettingsHolder import org.codehaus.groovy.grails.commons.ApplicationHolder import groovy.text.SimpleTemplateEngine -class TransientGrailsLdapServer implements InitializingBean, DisposableBean, BeanNameAware { +class TransientGrailsLdapServer implements InitializingBean, DisposableBean, BeanNameAware, ServletContextAware { final static configOptions = ["port", "base", "indexed"] final static ldifFileNameFilter = [accept: { File dir, String name -> name.endsWith(".ldif") }] as FilenameFilter String beanName + ServletContext servletContext Integer port = 10389 String base = "dc=grails,dc=org" @@ -262,7 +266,7 @@ } private getWorkDir() { - def base = ServletContextHolder.servletContext ? WebUtils.getTempDir(ServletContextHolder.servletContext) : new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) + def base = servletContext ? WebUtils.getTempDir(servletContext) : new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) new File(base, "ldap-servers/$beanName") } -} \ No newline at end of file +} -- Alex Kiernan --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
Hi,
Thanks for the patch. I've moved the source to GitHub. If you send a pull request with the change I'll release a new version immediately. On 30/03/2012, at 11:20 AM, Alex Kiernan wrote: > We've run into a problem with grails-ldap-server - we're guessing it's > down to order of ServletContextHolder bean initialisation and the > afterPropertiesSet method getting called. The fix is trivial: > > Index: plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy > =================================================================== > --- plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy > (revision 2546) > +++ plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy > (working copy) > @@ -1,5 +1,7 @@ > package grails.ldap.server > > +import javax.servlet.ServletContext > + > import org.apache.directory.server.core.DefaultDirectoryService > import org.apache.directory.server.ldap.LdapService > import org.apache.directory.server.protocol.shared.SocketAcceptor > @@ -11,24 +13,26 @@ > import org.apache.directory.shared.ldap.exception.LdapNameNotFoundException > > import org.springframework.web.util.WebUtils > -import org.codehaus.groovy.grails.web.context.ServletContextHolder > > import org.springframework.beans.factory.InitializingBean > import org.springframework.beans.factory.DisposableBean > import org.springframework.beans.factory.BeanNameAware > > +import org.springframework.web.context.ServletContextAware > + > import grails.util.BuildSettingsHolder > > import org.codehaus.groovy.grails.commons.ApplicationHolder > > import groovy.text.SimpleTemplateEngine > > -class TransientGrailsLdapServer implements InitializingBean, > DisposableBean, BeanNameAware { > +class TransientGrailsLdapServer implements InitializingBean, > DisposableBean, BeanNameAware, ServletContextAware { > > final static configOptions = ["port", "base", "indexed"] > final static ldifFileNameFilter = [accept: { File dir, String > name -> name.endsWith(".ldif") }] as FilenameFilter > > String beanName > + ServletContext servletContext > > Integer port = 10389 > String base = "dc=grails,dc=org" > @@ -262,7 +266,7 @@ > } > > private getWorkDir() { > - def base = ServletContextHolder.servletContext ? > WebUtils.getTempDir(ServletContextHolder.servletContext) : new > File(BuildSettingsHolder.settings?.projectWorkDir, beanName) > + def base = servletContext ? > WebUtils.getTempDir(servletContext) : new > File(BuildSettingsHolder.settings?.projectWorkDir, beanName) > new File(base, "ldap-servers/$beanName") > } > -} > \ No newline at end of file > +} > > > -- > Alex Kiernan > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
Will do - thanks for the quick response!
On Fri, Mar 30, 2012 at 2:17 PM, [hidden email] <[hidden email]> wrote: > Hi, > > Thanks for the patch. > > I've moved the source to GitHub. If you send a pull request with the change I'll release a new version immediately. > > On 30/03/2012, at 11:20 AM, Alex Kiernan wrote: > >> We've run into a problem with grails-ldap-server - we're guessing it's >> down to order of ServletContextHolder bean initialisation and the >> afterPropertiesSet method getting called. The fix is trivial: >> >> Index: plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >> =================================================================== >> --- plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >> (revision 2546) >> +++ plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >> (working copy) >> @@ -1,5 +1,7 @@ >> package grails.ldap.server >> >> +import javax.servlet.ServletContext >> + >> import org.apache.directory.server.core.DefaultDirectoryService >> import org.apache.directory.server.ldap.LdapService >> import org.apache.directory.server.protocol.shared.SocketAcceptor >> @@ -11,24 +13,26 @@ >> import org.apache.directory.shared.ldap.exception.LdapNameNotFoundException >> >> import org.springframework.web.util.WebUtils >> -import org.codehaus.groovy.grails.web.context.ServletContextHolder >> >> import org.springframework.beans.factory.InitializingBean >> import org.springframework.beans.factory.DisposableBean >> import org.springframework.beans.factory.BeanNameAware >> >> +import org.springframework.web.context.ServletContextAware >> + >> import grails.util.BuildSettingsHolder >> >> import org.codehaus.groovy.grails.commons.ApplicationHolder >> >> import groovy.text.SimpleTemplateEngine >> >> -class TransientGrailsLdapServer implements InitializingBean, >> DisposableBean, BeanNameAware { >> +class TransientGrailsLdapServer implements InitializingBean, >> DisposableBean, BeanNameAware, ServletContextAware { >> >> final static configOptions = ["port", "base", "indexed"] >> final static ldifFileNameFilter = [accept: { File dir, String >> name -> name.endsWith(".ldif") }] as FilenameFilter >> >> String beanName >> + ServletContext servletContext >> >> Integer port = 10389 >> String base = "dc=grails,dc=org" >> @@ -262,7 +266,7 @@ >> } >> >> private getWorkDir() { >> - def base = ServletContextHolder.servletContext ? >> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >> + def base = servletContext ? >> WebUtils.getTempDir(servletContext) : new >> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >> new File(base, "ldap-servers/$beanName") >> } >> -} >> \ No newline at end of file >> +} >> >> >> -- >> Alex Kiernan >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > -- Alex Kiernan --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
I just pushed a 1.0-SNAPSHOT version with your fix.
Can you test it out please and let me know if it works for you. If so, I'll push the final. On 02/04/2012, at 1:28 PM, Alex Kiernan wrote: > Will do - thanks for the quick response! > > On Fri, Mar 30, 2012 at 2:17 PM, [hidden email] <[hidden email]> wrote: >> Hi, >> >> Thanks for the patch. >> >> I've moved the source to GitHub. If you send a pull request with the change I'll release a new version immediately. >> >> On 30/03/2012, at 11:20 AM, Alex Kiernan wrote: >> >>> We've run into a problem with grails-ldap-server - we're guessing it's >>> down to order of ServletContextHolder bean initialisation and the >>> afterPropertiesSet method getting called. The fix is trivial: >>> >>> Index: plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>> =================================================================== >>> --- plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>> (revision 2546) >>> +++ plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>> (working copy) >>> @@ -1,5 +1,7 @@ >>> package grails.ldap.server >>> >>> +import javax.servlet.ServletContext >>> + >>> import org.apache.directory.server.core.DefaultDirectoryService >>> import org.apache.directory.server.ldap.LdapService >>> import org.apache.directory.server.protocol.shared.SocketAcceptor >>> @@ -11,24 +13,26 @@ >>> import org.apache.directory.shared.ldap.exception.LdapNameNotFoundException >>> >>> import org.springframework.web.util.WebUtils >>> -import org.codehaus.groovy.grails.web.context.ServletContextHolder >>> >>> import org.springframework.beans.factory.InitializingBean >>> import org.springframework.beans.factory.DisposableBean >>> import org.springframework.beans.factory.BeanNameAware >>> >>> +import org.springframework.web.context.ServletContextAware >>> + >>> import grails.util.BuildSettingsHolder >>> >>> import org.codehaus.groovy.grails.commons.ApplicationHolder >>> >>> import groovy.text.SimpleTemplateEngine >>> >>> -class TransientGrailsLdapServer implements InitializingBean, >>> DisposableBean, BeanNameAware { >>> +class TransientGrailsLdapServer implements InitializingBean, >>> DisposableBean, BeanNameAware, ServletContextAware { >>> >>> final static configOptions = ["port", "base", "indexed"] >>> final static ldifFileNameFilter = [accept: { File dir, String >>> name -> name.endsWith(".ldif") }] as FilenameFilter >>> >>> String beanName >>> + ServletContext servletContext >>> >>> Integer port = 10389 >>> String base = "dc=grails,dc=org" >>> @@ -262,7 +266,7 @@ >>> } >>> >>> private getWorkDir() { >>> - def base = ServletContextHolder.servletContext ? >>> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>> + def base = servletContext ? >>> WebUtils.getTempDir(servletContext) : new >>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>> new File(base, "ldap-servers/$beanName") >>> } >>> -} >>> \ No newline at end of file >>> +} >>> >>> >>> -- >>> Alex Kiernan >>> >>> --------------------------------------------------------------------- >>> To unsubscribe from this list, please visit: >>> >>> http://xircles.codehaus.org/manage_email >>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> > > > > -- > Alex Kiernan > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
Sorry, with holidays over Easter we've only just got around to checking it...
Assuming it's this snapshot: http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? The versions are all updated and the libs stripped out, so it's not just an accidental copy of 0.1.8! On Tue, Apr 3, 2012 at 1:01 PM, [hidden email] <[hidden email]> wrote: > I just pushed a 1.0-SNAPSHOT version with your fix. > > Can you test it out please and let me know if it works for you. If so, I'll push the final. > > On 02/04/2012, at 1:28 PM, Alex Kiernan wrote: > >> Will do - thanks for the quick response! >> >> On Fri, Mar 30, 2012 at 2:17 PM, [hidden email] <[hidden email]> wrote: >>> Hi, >>> >>> Thanks for the patch. >>> >>> I've moved the source to GitHub. If you send a pull request with the change I'll release a new version immediately. >>> >>> On 30/03/2012, at 11:20 AM, Alex Kiernan wrote: >>> >>>> We've run into a problem with grails-ldap-server - we're guessing it's >>>> down to order of ServletContextHolder bean initialisation and the >>>> afterPropertiesSet method getting called. The fix is trivial: >>>> >>>> Index: plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>> =================================================================== >>>> --- plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>> (revision 2546) >>>> +++ plugins/ldap-server-0.1.8/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>> (working copy) >>>> @@ -1,5 +1,7 @@ >>>> package grails.ldap.server >>>> >>>> +import javax.servlet.ServletContext >>>> + >>>> import org.apache.directory.server.core.DefaultDirectoryService >>>> import org.apache.directory.server.ldap.LdapService >>>> import org.apache.directory.server.protocol.shared.SocketAcceptor >>>> @@ -11,24 +13,26 @@ >>>> import org.apache.directory.shared.ldap.exception.LdapNameNotFoundException >>>> >>>> import org.springframework.web.util.WebUtils >>>> -import org.codehaus.groovy.grails.web.context.ServletContextHolder >>>> >>>> import org.springframework.beans.factory.InitializingBean >>>> import org.springframework.beans.factory.DisposableBean >>>> import org.springframework.beans.factory.BeanNameAware >>>> >>>> +import org.springframework.web.context.ServletContextAware >>>> + >>>> import grails.util.BuildSettingsHolder >>>> >>>> import org.codehaus.groovy.grails.commons.ApplicationHolder >>>> >>>> import groovy.text.SimpleTemplateEngine >>>> >>>> -class TransientGrailsLdapServer implements InitializingBean, >>>> DisposableBean, BeanNameAware { >>>> +class TransientGrailsLdapServer implements InitializingBean, >>>> DisposableBean, BeanNameAware, ServletContextAware { >>>> >>>> final static configOptions = ["port", "base", "indexed"] >>>> final static ldifFileNameFilter = [accept: { File dir, String >>>> name -> name.endsWith(".ldif") }] as FilenameFilter >>>> >>>> String beanName >>>> + ServletContext servletContext >>>> >>>> Integer port = 10389 >>>> String base = "dc=grails,dc=org" >>>> @@ -262,7 +266,7 @@ >>>> } >>>> >>>> private getWorkDir() { >>>> - def base = ServletContextHolder.servletContext ? >>>> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >>>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>>> + def base = servletContext ? >>>> WebUtils.getTempDir(servletContext) : new >>>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>>> new File(base, "ldap-servers/$beanName") >>>> } >>>> -} >>>> \ No newline at end of file >>>> +} >>>> >>>> >>>> -- >>>> Alex Kiernan >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe from this list, please visit: >>>> >>>> http://xircles.codehaus.org/manage_email >>>> >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe from this list, please visit: >>> >>> http://xircles.codehaus.org/manage_email >>> >>> >> >> >> >> -- >> Alex Kiernan >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > -- Alex Kiernan --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: > Sorry, with holidays over Easter we've only just got around to checking it... > > Assuming it's this snapshot: > > http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip > > Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? > > The versions are all updated and the libs stripped out, so it's not > just an accidental copy of 0.1.8! This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy Can you confirm that it's not working? --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
On Thu, Apr 12, 2012 at 12:09 PM, [hidden email] <[hidden email]> wrote:
> > On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: > >> Sorry, with holidays over Easter we've only just got around to checking it... >> >> Assuming it's this snapshot: >> >> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >> >> Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? >> >> The versions are all updated and the libs stripped out, so it's not >> just an accidental copy of 0.1.8! > > This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy > > Can you confirm that it's not working? Am I on the right snapshot? Pulling it down from http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip I get a TransientGrailsLdapServer which has a getWorkDir implementation which is: private getWorkDir() { def base = ServletContextHolder.servletContext ? WebUtils.getTempDir(ServletContextHolder.servletContext) : new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) new File(base, "ldap-servers/$beanName") } as opposed to: private getWorkDir() { def base = servletContext ? WebUtils.getTempDir(servletContext) : new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) new File(base, "ldap-servers/$beanName") } which is in https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy The merge looks right, I think I'm just not picking the snapshot you intended? --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
On 12/04/2012, at 10:15 PM, Alex Kiernan wrote: > On Thu, Apr 12, 2012 at 12:09 PM, [hidden email] <[hidden email]> wrote: >> >> On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: >> >>> Sorry, with holidays over Easter we've only just got around to checking it... >>> >>> Assuming it's this snapshot: >>> >>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>> >>> Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? >>> >>> The versions are all updated and the libs stripped out, so it's not >>> just an accidental copy of 0.1.8! >> >> This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >> >> Can you confirm that it's not working? > > Am I on the right snapshot? Pulling it down from > > http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip > > I get a TransientGrailsLdapServer which has a getWorkDir > implementation which is: > > private getWorkDir() { > def base = ServletContextHolder.servletContext ? > WebUtils.getTempDir(ServletContextHolder.servletContext) : new > File(BuildSettingsHolder.settings?.projectWorkDir, beanName) > new File(base, "ldap-servers/$beanName") > } > > as opposed to: > > > private getWorkDir() { > def base = servletContext ? WebUtils.getTempDir(servletContext) : > new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) > new File(base, "ldap-servers/$beanName") > } > > which is in https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy > > The merge looks right, I think I'm just not picking the snapshot you intended? Unsure what happened. I just re-released and the new snapshot from that URL has the change. --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
On Fri, Apr 13, 2012 at 11:27 AM, [hidden email] <[hidden email]> wrote:
> > On 12/04/2012, at 10:15 PM, Alex Kiernan wrote: > >> On Thu, Apr 12, 2012 at 12:09 PM, [hidden email] <[hidden email]> wrote: >>> >>> On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: >>> >>>> Sorry, with holidays over Easter we've only just got around to checking it... >>>> >>>> Assuming it's this snapshot: >>>> >>>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>>> >>>> Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? >>>> >>>> The versions are all updated and the libs stripped out, so it's not >>>> just an accidental copy of 0.1.8! >>> >>> This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>> >>> Can you confirm that it's not working? >> >> Am I on the right snapshot? Pulling it down from >> >> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >> >> I get a TransientGrailsLdapServer which has a getWorkDir >> implementation which is: >> >> private getWorkDir() { >> def base = ServletContextHolder.servletContext ? >> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >> new File(base, "ldap-servers/$beanName") >> } >> >> as opposed to: >> >> >> private getWorkDir() { >> def base = servletContext ? WebUtils.getTempDir(servletContext) : >> new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >> new File(base, "ldap-servers/$beanName") >> } >> >> which is in https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >> >> The merge looks right, I think I'm just not picking the snapshot you intended? > > Unsure what happened. > > I just re-released and the new snapshot from that URL has the change. > Something's not playing - I wondered if it was the proxy we're normally stuck behind, but going from somewhere direct we're still getting the same problem. I wondered if it's related to the announce on the old plugins repo going read only? A wget looks like this if this helps: --2012-04-13 12:22:32-- http://plugins.grails.org/grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip Resolving plugins.grails.org (plugins.grails.org)... 208.91.2.18 Connecting to plugins.grails.org (plugins.grails.org)|208.91.2.18|:80... connected. HTTP request sent, awaiting response... HTTP/1.1 200 OK Server: Apache/2.2.3 (Red Hat) Last-Modified: Fri, 13 Apr 2012 10:21:28 GMT ETag: "81311//grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip" Accept-Ranges: bytes Content-Type: application/octet-stream X-Cache: MISS from s2-prod-grails-w1.vmware.com X-Cache-Lookup: MISS from s2-prod-grails-w1.vmware.com:3128 Via: 1.0 s2-prod-grails-w1.vmware.com:3128 (squid/2.6.STABLE21) Via: 1.1 grails.org Content-Length: 9718 Accept-Ranges: bytes Date: Fri, 13 Apr 2012 11:22:30 GMT X-Varnish: 1423290135 Age: 0 Via: 1.1 varnish Connection: keep-alive Length: 9718 (9.5K) [application/octet-stream] Saving to: `grails-ldap-server-1.0-SNAPSHOT.zip' 100%[======================================>] 9,718 --.-K/s in 0.1s 2012-04-13 12:22:33 (67.0 KB/s) - `grails-ldap-server-1.0-SNAPSHOT.zip' saved [9718/9718] -- Alex Kiernan --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
On Fri, Apr 13, 2012 at 12:52 PM, Alex Kiernan <[hidden email]> wrote:
> On Fri, Apr 13, 2012 at 11:27 AM, [hidden email] <[hidden email]> wrote: >> >> On 12/04/2012, at 10:15 PM, Alex Kiernan wrote: >> >>> On Thu, Apr 12, 2012 at 12:09 PM, [hidden email] <[hidden email]> wrote: >>>> >>>> On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: >>>> >>>>> Sorry, with holidays over Easter we've only just got around to checking it... >>>>> >>>>> Assuming it's this snapshot: >>>>> >>>>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>>>> >>>>> Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? >>>>> >>>>> The versions are all updated and the libs stripped out, so it's not >>>>> just an accidental copy of 0.1.8! >>>> >>>> This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>> >>>> Can you confirm that it's not working? >>> >>> Am I on the right snapshot? Pulling it down from >>> >>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>> >>> I get a TransientGrailsLdapServer which has a getWorkDir >>> implementation which is: >>> >>> private getWorkDir() { >>> def base = ServletContextHolder.servletContext ? >>> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>> new File(base, "ldap-servers/$beanName") >>> } >>> >>> as opposed to: >>> >>> >>> private getWorkDir() { >>> def base = servletContext ? WebUtils.getTempDir(servletContext) : >>> new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>> new File(base, "ldap-servers/$beanName") >>> } >>> >>> which is in https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>> >>> The merge looks right, I think I'm just not picking the snapshot you intended? >> >> Unsure what happened. >> >> I just re-released and the new snapshot from that URL has the change. >> > > Something's not playing - I wondered if it was the proxy we're > normally stuck behind, but going from somewhere direct we're still > getting the same problem. I wondered if it's related to the announce > on the old plugins repo going read only? > > A wget looks like this if this helps: > > --2012-04-13 12:22:32-- > http://plugins.grails.org/grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip > Resolving plugins.grails.org (plugins.grails.org)... 208.91.2.18 > Connecting to plugins.grails.org > (plugins.grails.org)|208.91.2.18|:80... connected. > HTTP request sent, awaiting response... > HTTP/1.1 200 OK > Server: Apache/2.2.3 (Red Hat) > Last-Modified: Fri, 13 Apr 2012 10:21:28 GMT > ETag: "81311//grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip" > Accept-Ranges: bytes > Content-Type: application/octet-stream > X-Cache: MISS from s2-prod-grails-w1.vmware.com > X-Cache-Lookup: MISS from s2-prod-grails-w1.vmware.com:3128 > Via: 1.0 s2-prod-grails-w1.vmware.com:3128 (squid/2.6.STABLE21) > Via: 1.1 grails.org > Content-Length: 9718 > Accept-Ranges: bytes > Date: Fri, 13 Apr 2012 11:22:30 GMT > X-Varnish: 1423290135 > Age: 0 > Via: 1.1 varnish > Connection: keep-alive > Length: 9718 (9.5K) [application/octet-stream] > Saving to: `grails-ldap-server-1.0-SNAPSHOT.zip' > > 100%[======================================>] 9,718 --.-K/s in 0.1s > > 2012-04-13 12:22:33 (67.0 KB/s) - > `grails-ldap-server-1.0-SNAPSHOT.zip' saved [9718/9718] > Meant to say if I do a package-plugin from a checkout of your git repo I get a plugin which does have the right things in it, so it looks like this is just a publish problem! -- Alex Kiernan --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
In reply to this post by Alex Kiernan
On 13/04/2012, at 12:52 PM, Alex Kiernan wrote: > On Fri, Apr 13, 2012 at 11:27 AM, [hidden email] <[hidden email]> wrote: >> >> On 12/04/2012, at 10:15 PM, Alex Kiernan wrote: >> >>> On Thu, Apr 12, 2012 at 12:09 PM, [hidden email] <[hidden email]> wrote: >>>> >>>> On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: >>>> >>>>> Sorry, with holidays over Easter we've only just got around to checking it... >>>>> >>>>> Assuming it's this snapshot: >>>>> >>>>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>>>> >>>>> Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? >>>>> >>>>> The versions are all updated and the libs stripped out, so it's not >>>>> just an accidental copy of 0.1.8! >>>> >>>> This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>> >>>> Can you confirm that it's not working? >>> >>> Am I on the right snapshot? Pulling it down from >>> >>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>> >>> I get a TransientGrailsLdapServer which has a getWorkDir >>> implementation which is: >>> >>> private getWorkDir() { >>> def base = ServletContextHolder.servletContext ? >>> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>> new File(base, "ldap-servers/$beanName") >>> } >>> >>> as opposed to: >>> >>> >>> private getWorkDir() { >>> def base = servletContext ? WebUtils.getTempDir(servletContext) : >>> new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>> new File(base, "ldap-servers/$beanName") >>> } >>> >>> which is in https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>> >>> The merge looks right, I think I'm just not picking the snapshot you intended? >> >> Unsure what happened. >> >> I just re-released and the new snapshot from that URL has the change. >> > > Something's not playing - I wondered if it was the proxy we're > normally stuck behind, but going from somewhere direct we're still > getting the same problem. I wondered if it's related to the announce > on the old plugins repo going read only? > > A wget looks like this if this helps: > > --2012-04-13 12:22:32-- > http://plugins.grails.org/grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip > Resolving plugins.grails.org (plugins.grails.org)... 208.91.2.18 > Connecting to plugins.grails.org > (plugins.grails.org)|208.91.2.18|:80... connected. > HTTP request sent, awaiting response... > HTTP/1.1 200 OK > Server: Apache/2.2.3 (Red Hat) > Last-Modified: Fri, 13 Apr 2012 10:21:28 GMT > ETag: "81311//grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip" > Accept-Ranges: bytes > Content-Type: application/octet-stream > X-Cache: MISS from s2-prod-grails-w1.vmware.com > X-Cache-Lookup: MISS from s2-prod-grails-w1.vmware.com:3128 > Via: 1.0 s2-prod-grails-w1.vmware.com:3128 (squid/2.6.STABLE21) > Via: 1.1 grails.org > Content-Length: 9718 > Accept-Ranges: bytes > Date: Fri, 13 Apr 2012 11:22:30 GMT > X-Varnish: 1423290135 > Age: 0 > Via: 1.1 varnish > Connection: keep-alive > Length: 9718 (9.5K) [application/octet-stream] > Saving to: `grails-ldap-server-1.0-SNAPSHOT.zip' > > 100%[======================================>] 9,718 --.-K/s in 0.1s > > 2012-04-13 12:22:33 (67.0 KB/s) - > `grails-ldap-server-1.0-SNAPSHOT.zip' saved [9718/9718] If download the zip from that URL, I get the new changes. Can you try from somewhere else? --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
On Fri, Apr 13, 2012 at 12:57 PM, [hidden email] <[hidden email]> wrote:
> > On 13/04/2012, at 12:52 PM, Alex Kiernan wrote: > >> On Fri, Apr 13, 2012 at 11:27 AM, [hidden email] <[hidden email]> wrote: >>> >>> On 12/04/2012, at 10:15 PM, Alex Kiernan wrote: >>> >>>> On Thu, Apr 12, 2012 at 12:09 PM, [hidden email] <[hidden email]> wrote: >>>>> >>>>> On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: >>>>> >>>>>> Sorry, with holidays over Easter we've only just got around to checking it... >>>>>> >>>>>> Assuming it's this snapshot: >>>>>> >>>>>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>>>>> >>>>>> Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? >>>>>> >>>>>> The versions are all updated and the libs stripped out, so it's not >>>>>> just an accidental copy of 0.1.8! >>>>> >>>>> This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>>> >>>>> Can you confirm that it's not working? >>>> >>>> Am I on the right snapshot? Pulling it down from >>>> >>>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>>> >>>> I get a TransientGrailsLdapServer which has a getWorkDir >>>> implementation which is: >>>> >>>> private getWorkDir() { >>>> def base = ServletContextHolder.servletContext ? >>>> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >>>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>>> new File(base, "ldap-servers/$beanName") >>>> } >>>> >>>> as opposed to: >>>> >>>> >>>> private getWorkDir() { >>>> def base = servletContext ? WebUtils.getTempDir(servletContext) : >>>> new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>>> new File(base, "ldap-servers/$beanName") >>>> } >>>> >>>> which is in https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>> >>>> The merge looks right, I think I'm just not picking the snapshot you intended? >>> >>> Unsure what happened. >>> >>> I just re-released and the new snapshot from that URL has the change. >>> >> >> Something's not playing - I wondered if it was the proxy we're >> normally stuck behind, but going from somewhere direct we're still >> getting the same problem. I wondered if it's related to the announce >> on the old plugins repo going read only? >> >> A wget looks like this if this helps: >> >> --2012-04-13 12:22:32-- >> http://plugins.grails.org/grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip >> Resolving plugins.grails.org (plugins.grails.org)... 208.91.2.18 >> Connecting to plugins.grails.org >> (plugins.grails.org)|208.91.2.18|:80... connected. >> HTTP request sent, awaiting response... >> HTTP/1.1 200 OK >> Server: Apache/2.2.3 (Red Hat) >> Last-Modified: Fri, 13 Apr 2012 10:21:28 GMT >> ETag: "81311//grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip" >> Accept-Ranges: bytes >> Content-Type: application/octet-stream >> X-Cache: MISS from s2-prod-grails-w1.vmware.com >> X-Cache-Lookup: MISS from s2-prod-grails-w1.vmware.com:3128 >> Via: 1.0 s2-prod-grails-w1.vmware.com:3128 (squid/2.6.STABLE21) >> Via: 1.1 grails.org >> Content-Length: 9718 >> Accept-Ranges: bytes >> Date: Fri, 13 Apr 2012 11:22:30 GMT >> X-Varnish: 1423290135 >> Age: 0 >> Via: 1.1 varnish >> Connection: keep-alive >> Length: 9718 (9.5K) [application/octet-stream] >> Saving to: `grails-ldap-server-1.0-SNAPSHOT.zip' >> >> 100%[======================================>] 9,718 --.-K/s in 0.1s >> >> 2012-04-13 12:22:33 (67.0 KB/s) - >> `grails-ldap-server-1.0-SNAPSHOT.zip' saved [9718/9718] > > If download the zip from that URL, I get the new changes. > > Can you try from somewhere else? > Same problem pulling it from an East Coast EC2 box: $ wget http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip --2012-04-13 12:12:27-- http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip Resolving plugins.grails.org... 208.91.2.18 Connecting to plugins.grails.org|208.91.2.18|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 9718 (9.5K) [application/octet-stream] Saving to: `grails-ldap-server-1.0-SNAPSHOT.zip' 100%[======================================>] 9,718 --.-K/s in 0.08s 2012-04-13 12:12:27 (119 KB/s) - `grails-ldap-server-1.0-SNAPSHOT.zip' saved [9718/9718] $ unzip -l grails-ldap-server-1.0-SNAPSHOT.zip Archive: grails-ldap-server-1.0-SNAPSHOT.zip Length Date Time Name --------- ---------- ----- ---- 11558 2012-03-30 12:52 LICENSE 1685 2012-04-03 12:41 LdapServerGrailsPlugin.groovy 132 2012-04-13 11:17 application.properties 1255 2012-04-13 11:17 plugin.xml 522 2012-03-30 12:52 scripts/_Events.groovy 51 2012-03-30 12:52 scripts/_Install.groovy 210 2012-03-30 12:52 scripts/_Uninstall.groovy 420 2012-03-30 12:52 scripts/_Upgrade.groovy 7123 2012-03-30 12:52 src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy 451 2012-04-13 11:17 dependencies.groovy --------- ------- 23407 10 files $ -- Alex Kiernan --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
|
On 13/04/2012, at 1:18 PM, Alex Kiernan wrote: > On Fri, Apr 13, 2012 at 12:57 PM, [hidden email] <[hidden email]> wrote: >> >> On 13/04/2012, at 12:52 PM, Alex Kiernan wrote: >> >>> On Fri, Apr 13, 2012 at 11:27 AM, [hidden email] <[hidden email]> wrote: >>>> >>>> On 12/04/2012, at 10:15 PM, Alex Kiernan wrote: >>>> >>>>> On Thu, Apr 12, 2012 at 12:09 PM, [hidden email] <[hidden email]> wrote: >>>>>> >>>>>> On 12/04/2012, at 11:33 AM, Alex Kiernan wrote: >>>>>> >>>>>>> Sorry, with holidays over Easter we've only just got around to checking it... >>>>>>> >>>>>>> Assuming it's this snapshot: >>>>>>> >>>>>>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>>>>>> >>>>>>> Doesn't seem like it's got the updated TransientGrailsLdapServer.groovy in it? >>>>>>> >>>>>>> The versions are all updated and the libs stripped out, so it's not >>>>>>> just an accidental copy of 0.1.8! >>>>>> >>>>>> This is what went in: https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>>>> >>>>>> Can you confirm that it's not working? >>>>> >>>>> Am I on the right snapshot? Pulling it down from >>>>> >>>>> http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip >>>>> >>>>> I get a TransientGrailsLdapServer which has a getWorkDir >>>>> implementation which is: >>>>> >>>>> private getWorkDir() { >>>>> def base = ServletContextHolder.servletContext ? >>>>> WebUtils.getTempDir(ServletContextHolder.servletContext) : new >>>>> File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>>>> new File(base, "ldap-servers/$beanName") >>>>> } >>>>> >>>>> as opposed to: >>>>> >>>>> >>>>> private getWorkDir() { >>>>> def base = servletContext ? WebUtils.getTempDir(servletContext) : >>>>> new File(BuildSettingsHolder.settings?.projectWorkDir, beanName) >>>>> new File(base, "ldap-servers/$beanName") >>>>> } >>>>> >>>>> which is in https://github.com/alkemist/grails-ldap-server/blob/master/src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy >>>>> >>>>> The merge looks right, I think I'm just not picking the snapshot you intended? >>>> >>>> Unsure what happened. >>>> >>>> I just re-released and the new snapshot from that URL has the change. >>>> >>> >>> Something's not playing - I wondered if it was the proxy we're >>> normally stuck behind, but going from somewhere direct we're still >>> getting the same problem. I wondered if it's related to the announce >>> on the old plugins repo going read only? >>> >>> A wget looks like this if this helps: >>> >>> --2012-04-13 12:22:32-- >>> http://plugins.grails.org/grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip >>> Resolving plugins.grails.org (plugins.grails.org)... 208.91.2.18 >>> Connecting to plugins.grails.org >>> (plugins.grails.org)|208.91.2.18|:80... connected. >>> HTTP request sent, awaiting response... >>> HTTP/1.1 200 OK >>> Server: Apache/2.2.3 (Red Hat) >>> Last-Modified: Fri, 13 Apr 2012 10:21:28 GMT >>> ETag: "81311//grails-ldap-server/trunk/grails-ldap-server-1.0-SNAPSHOT.zip" >>> Accept-Ranges: bytes >>> Content-Type: application/octet-stream >>> X-Cache: MISS from s2-prod-grails-w1.vmware.com >>> X-Cache-Lookup: MISS from s2-prod-grails-w1.vmware.com:3128 >>> Via: 1.0 s2-prod-grails-w1.vmware.com:3128 (squid/2.6.STABLE21) >>> Via: 1.1 grails.org >>> Content-Length: 9718 >>> Accept-Ranges: bytes >>> Date: Fri, 13 Apr 2012 11:22:30 GMT >>> X-Varnish: 1423290135 >>> Age: 0 >>> Via: 1.1 varnish >>> Connection: keep-alive >>> Length: 9718 (9.5K) [application/octet-stream] >>> Saving to: `grails-ldap-server-1.0-SNAPSHOT.zip' >>> >>> 100%[======================================>] 9,718 --.-K/s in 0.1s >>> >>> 2012-04-13 12:22:33 (67.0 KB/s) - >>> `grails-ldap-server-1.0-SNAPSHOT.zip' saved [9718/9718] >> >> If download the zip from that URL, I get the new changes. >> >> Can you try from somewhere else? >> > > Same problem pulling it from an East Coast EC2 box: > > $ wget http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip > --2012-04-13 12:12:27-- > http://plugins.grails.org/grails-ldap-server/tags/RELEASE_1_0-SNAPSHOT/grails-ldap-server-1.0-SNAPSHOT.zip > Resolving plugins.grails.org... 208.91.2.18 > Connecting to plugins.grails.org|208.91.2.18|:80... connected. > HTTP request sent, awaiting response... 200 OK > Length: 9718 (9.5K) [application/octet-stream] > Saving to: `grails-ldap-server-1.0-SNAPSHOT.zip' > > 100%[======================================>] 9,718 --.-K/s in 0.08s > > 2012-04-13 12:12:27 (119 KB/s) - `grails-ldap-server-1.0-SNAPSHOT.zip' > saved [9718/9718] > > $ unzip -l grails-ldap-server-1.0-SNAPSHOT.zip > Archive: grails-ldap-server-1.0-SNAPSHOT.zip > Length Date Time Name > --------- ---------- ----- ---- > 11558 2012-03-30 12:52 LICENSE > 1685 2012-04-03 12:41 LdapServerGrailsPlugin.groovy > 132 2012-04-13 11:17 application.properties > 1255 2012-04-13 11:17 plugin.xml > 522 2012-03-30 12:52 scripts/_Events.groovy > 51 2012-03-30 12:52 scripts/_Install.groovy > 210 2012-03-30 12:52 scripts/_Uninstall.groovy > 420 2012-03-30 12:52 scripts/_Upgrade.groovy > 7123 2012-03-30 12:52 > src/groovy/grails/ldap/server/TransientGrailsLdapServer.groovy > 451 2012-04-13 11:17 dependencies.groovy > --------- ------- > 23407 10 files > $ Please send me the copy of TransientGrailsLdapServer.groovy that you are extracting. --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email |
| Powered by Nabble | Edit this page |
