Quantcast

Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

Jorge Uriarte Aretxaga
Hi there!

I used to have permissions for the PayPal plugin in the old repository, but given it is now under the umbrella of "grails-plugins" I forked and raised a pull request.
Anyone willing to accept it? (it's quite trivial, but it will help applications keep the locale when navigating to paypal checkout page)


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

Jorge Uriarte Aretxaga
mmmhh... anything missing, beyond committer bandwidth?
It's a small, cosmetic issue, but I'm far more worried about the contribution process itself, than about the fix itself... (even though I'd like to avoid forking for such a trivial thing...)

Thanks!
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Wed, Jun 13, 2012 at 7:00 PM, Jorge Uriarte Aretxaga <[hidden email]> wrote:
Hi there!

I used to have permissions for the PayPal plugin in the old repository, but given it is now under the umbrella of "grails-plugins" I forked and raised a pull request.
Anyone willing to accept it? (it's quite trivial, but it will help applications keep the locale when navigating to paypal checkout page)



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

Graeme Rocher-2
If you're willing and eager to take over ownership of the plugin then I'm happy to provide commit rights to the master branch, it is one of those plugins that isn't often given priority

-- 
Graeme Rocher

On Monday, July 16, 2012 at 10:41 AM, Jorge Uriarte Aretxaga wrote:

mmmhh... anything missing, beyond committer bandwidth?
It's a small, cosmetic issue, but I'm far more worried about the contribution process itself, than about the fix itself... (even though I'd like to avoid forking for such a trivial thing...)

Thanks!
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Wed, Jun 13, 2012 at 7:00 PM, Jorge Uriarte Aretxaga <[hidden email]> wrote:
Hi there!

I used to have permissions for the PayPal plugin in the old repository, but given it is now under the umbrella of "grails-plugins" I forked and raised a pull request.
Anyone willing to accept it? (it's quite trivial, but it will help applications keep the locale when navigating to paypal checkout page)




Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

Jorge Uriarte Aretxaga

For sure, it hasn't that much activity and we use it intensively.

Thanks!

El 16/07/2012 15:21, "Graeme Rocher" <[hidden email]> escribió:
If you're willing and eager to take over ownership of the plugin then I'm happy to provide commit rights to the master branch, it is one of those plugins that isn't often given priority

-- 
Graeme Rocher

On Monday, July 16, 2012 at 10:41 AM, Jorge Uriarte Aretxaga wrote:

mmmhh... anything missing, beyond committer bandwidth?
It's a small, cosmetic issue, but I'm far more worried about the contribution process itself, than about the fix itself... (even though I'd like to avoid forking for such a trivial thing...)

Thanks!
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Wed, Jun 13, 2012 at 7:00 PM, Jorge Uriarte Aretxaga <[hidden email]> wrote:
Hi there!

I used to have permissions for the PayPal plugin in the old repository, but given it is now under the umbrella of "grails-plugins" I forked and raised a pull request.
Anyone willing to accept it? (it's quite trivial, but it will help applications keep the locale when navigating to paypal checkout page)




Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

Graeme Rocher-2
What is your github username?

-- 
Graeme Rocher

On Monday, July 16, 2012 at 4:13 PM, Jorge Uriarte Aretxaga wrote:

For sure, it hasn't that much activity and we use it intensively.

Thanks!

El 16/07/2012 15:21, "Graeme Rocher" <[hidden email]> escribió:
If you're willing and eager to take over ownership of the plugin then I'm happy to provide commit rights to the master branch, it is one of those plugins that isn't often given priority

-- 
Graeme Rocher

On Monday, July 16, 2012 at 10:41 AM, Jorge Uriarte Aretxaga wrote:

mmmhh... anything missing, beyond committer bandwidth?
It's a small, cosmetic issue, but I'm far more worried about the contribution process itself, than about the fix itself... (even though I'd like to avoid forking for such a trivial thing...)

Thanks!
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Wed, Jun 13, 2012 at 7:00 PM, Jorge Uriarte Aretxaga <[hidden email]> wrote:
Hi there!

I used to have permissions for the PayPal plugin in the old repository, but given it is now under the umbrella of "grails-plugins" I forked and raised a pull request.
Anyone willing to accept it? (it's quite trivial, but it will help applications keep the locale when navigating to paypal checkout page)





Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

Jorge Uriarte Aretxaga
jorgeuriarte
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Mon, Jul 16, 2012 at 5:48 PM, Graeme Rocher <[hidden email]> wrote:
What is your github username?

-- 
Graeme Rocher

On Monday, July 16, 2012 at 4:13 PM, Jorge Uriarte Aretxaga wrote:

For sure, it hasn't that much activity and we use it intensively.

Thanks!

El 16/07/2012 15:21, "Graeme Rocher" <[hidden email]> escribió:
If you're willing and eager to take over ownership of the plugin then I'm happy to provide commit rights to the master branch, it is one of those plugins that isn't often given priority

-- 
Graeme Rocher

On Monday, July 16, 2012 at 10:41 AM, Jorge Uriarte Aretxaga wrote:

mmmhh... anything missing, beyond committer bandwidth?
It's a small, cosmetic issue, but I'm far more worried about the contribution process itself, than about the fix itself... (even though I'd like to avoid forking for such a trivial thing...)

Thanks!
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Wed, Jun 13, 2012 at 7:00 PM, Jorge Uriarte Aretxaga <[hidden email]> wrote:
Hi there!

I used to have permissions for the PayPal plugin in the old repository, but given it is now under the umbrella of "grails-plugins" I forked and raised a pull request.
Anyone willing to accept it? (it's quite trivial, but it will help applications keep the locale when navigating to paypal checkout page)






Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Small fix (localization) for PayPal plugin... anything need to the the pull request integrated?

Graeme Rocher-2
Hi Jorge,

You should have permission to push changes directly to the paypal plugin now

Cheers

-- 
Graeme Rocher

On Monday, July 16, 2012 at 6:06 PM, Jorge Uriarte Aretxaga wrote:

jorgeuriarte
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Mon, Jul 16, 2012 at 5:48 PM, Graeme Rocher <[hidden email]> wrote:
What is your github username?

-- 
Graeme Rocher

On Monday, July 16, 2012 at 4:13 PM, Jorge Uriarte Aretxaga wrote:

For sure, it hasn't that much activity and we use it intensively.

Thanks!

El 16/07/2012 15:21, "Graeme Rocher" <[hidden email]> escribió:
If you're willing and eager to take over ownership of the plugin then I'm happy to provide commit rights to the master branch, it is one of those plugins that isn't often given priority

-- 
Graeme Rocher

On Monday, July 16, 2012 at 10:41 AM, Jorge Uriarte Aretxaga wrote:

mmmhh... anything missing, beyond committer bandwidth?
It's a small, cosmetic issue, but I'm far more worried about the contribution process itself, than about the fix itself... (even though I'd like to avoid forking for such a trivial thing...)

Thanks!
_
Jorge Uriarte Aretxaga
http://www.gailen.es
http://www.linkedin.com/in/jorgeuriarte



On Wed, Jun 13, 2012 at 7:00 PM, Jorge Uriarte Aretxaga <[hidden email]> wrote:
Hi there!

I used to have permissions for the PayPal plugin in the old repository, but given it is now under the umbrella of "grails-plugins" I forked and raised a pull request.
Anyone willing to accept it? (it's quite trivial, but it will help applications keep the locale when navigating to paypal checkout page)







Loading...