Some fixes are missing from 1.3.x branch

[dmurat]

It looks like GRAILS-6584, GRAILS-6592 and GRAILS-6788 are not applied on 1.3.x branch, although they are applied on master branch.
Is it possible to apply them on 1.3.x too?

Best regards,
Damir Murat

[Graeme Rocher-4]

I've applied GRAILS-6592 and GRAILS-6788 to the 1.3.x, since
GRAILS-6584 is a new feature I would like consensus from the rest of
the devs whether it makes sense to go into 1.3.6 or should wait for
1.4 M1

Cheers

On Wed, Nov 10, 2010 at 11:02 AM, dmurat <[hidden email]> wrote:

>
> It looks like GRAILS-6584, GRAILS-6592 and GRAILS-6788 are not applied on
> 1.3.x branch, although they are applied on master branch.
> Is it possible to apply them on 1.3.x too?
>
> Best regards,
> Damir Murat
> --
> View this message in context: http://grails.1312388.n4.nabble.com/Some-fixes-are-missing-from-1-3-x-branch-tp3035786p3035786.html
> Sent from the Grails - dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>

--
Graeme Rocher
Grails Project Lead
SpringSource - A Division of VMware
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[pledbrook]

> I've applied GRAILS-6592 and GRAILS-6788 to the 1.3.x, since
> GRAILS-6584 is a new feature I would like consensus from the rest of
> the devs whether it makes sense to go into 1.3.6 or should wait for
> 1.4 M1

I don't think we should add that to a patch release. It's too
significant a change and potential source of problems.

A couple of comments about the implementation:

1. I'd personally prefer to see * used as the wildcard rather than the
regular expression '.*'. The former is more common throughout Grails.

2. I don't really like the position of importFrom() determining
whether it overrides the explicit constraints or they override it.
Explicit constraints in a command object should always override those
that are imported in my view. I can just imagine people struggling to
understand why their explicit constraints aren't behaving as they
expect.

Other than that, sounds like a useful feature that many people will
appreciate. I know I've wanted something like that in the past.

Peter

--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

On 11/11/2010, at 7:18 AM, Peter Ledbrook wrote:

>> I've applied GRAILS-6592 and GRAILS-6788 to the 1.3.x, since
>> GRAILS-6584 is a new feature I would like consensus from the rest of
>> the devs whether it makes sense to go into 1.3.6 or should wait for
>> 1.4 M1
>
> I don't think we should add that to a patch release. It's too
> significant a change and potential source of problems.

I agree with Peter.

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email