Quantcast

Trouble back-fitting fix to Grails 2.5

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Trouble back-fitting fix to Grails 2.5

John Pandich
Hello, 

I am attempting to back fit https://github.com/grails/grails-data-mapping/commit/7415062050ea1a21a9c0650d2a22d6f1608af4fe to Grails 2.5. I have made the steps:

1) Make code changes to grails-data-mapping 3.1.5 (8479adc) because that is what sdkman pulls into grails 2.5.4 
2) Build the changes with "gradle build" and "gradle jar". 
3) replaced ~/.sdkman/candidates/grails/2.5.4/src/grails-datastore-gorm-3.1.5.RELEASE-sources.jar  with ~/../grails-data-mapping/grails-datastore-gorm/build/libs/grails-datastore-gorm-3.1.5.RELEASE-sources.jar because I assume all hibernate changes are bundled here
4) replaced ~/.sdkman/candidates/grails/2.5.4/lib/jars/org.grails/grails-datastore-gorm/grails-datastore-gorm-3.1.5.RELEASE.jar  with ~/../grails-data-mapping/grails-datastore-gorm/build/libs/grails-datastore-gorm-3.1.5.RELEASE-sources.jar because I assume all hibernate changes are bundled here

I am still seeing the same error (NullPointerException at at org.hibernate.engine.spi.BatchFetchQueue.removeBatchLoadableEntityKey(BatchFetchQueue.java:163)). I am not sure if the fix I back-fit was not the problem or if I am missing something in patching. Any help would be greatly appreciated.

Thank you,
John 

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/907301e5-4ffe-400f-8f1d-9d8ec340ab4a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Trouble back-fitting fix to Grails 2.5

John Pandich

correction:
4) replaced ~/.sdkman/candidates/grails/2.5.4/lib/jars/org.grails/grails-datastore-gorm/grails-datastore-gorm-3.1.5.RELEASE.jar  with ~/../grails-data-mapping/grails-datastore-gorm/build/libs/grails-datastore-gorm-3.1.5.RELEASE.jar because I assume all hibernate changes are bundled here
On Thursday, March 10, 2016 at 6:55:45 PM UTC-5, John Pandich wrote:
Hello, 

I am attempting to back fit <a href="https://github.com/grails/grails-data-mapping/commit/7415062050ea1a21a9c0650d2a22d6f1608af4fe" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fgrails%2Fgrails-data-mapping%2Fcommit%2F7415062050ea1a21a9c0650d2a22d6f1608af4fe\46sa\75D\46sntz\0751\46usg\75AFQjCNGi2wKhykcUBxQ41RMbOC8VzCWC3w&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fgrails%2Fgrails-data-mapping%2Fcommit%2F7415062050ea1a21a9c0650d2a22d6f1608af4fe\46sa\75D\46sntz\0751\46usg\75AFQjCNGi2wKhykcUBxQ41RMbOC8VzCWC3w&#39;;return true;">https://github.com/grails/grails-data-mapping/commit/7415062050ea1a21a9c0650d2a22d6f1608af4fe to Grails 2.5. I have made the steps:

1) Make code changes to grails-data-mapping 3.1.5 (<a href="https://github.com/grails/grails-data-mapping/commit/8479adc15f692cfd39d448aed4ef988511d30bb8" style="color:rgb(68,80,85);text-decoration:underline;display:inline-block;font-family:Consolas,&#39;Liberation Mono&#39;,Menlo,Courier,monospace;outline:0px;line-height:20px;background-color:rgb(242,249,252)" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fgrails%2Fgrails-data-mapping%2Fcommit%2F8479adc15f692cfd39d448aed4ef988511d30bb8\46sa\75D\46sntz\0751\46usg\75AFQjCNFsP9XFe6cQ08HELK7YTB5LuXPZCw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\75https%3A%2F%2Fgithub.com%2Fgrails%2Fgrails-data-mapping%2Fcommit%2F8479adc15f692cfd39d448aed4ef988511d30bb8\46sa\75D\46sntz\0751\46usg\75AFQjCNFsP9XFe6cQ08HELK7YTB5LuXPZCw&#39;;return true;">8479adc) because that is what sdkman pulls into grails 2.5.4 
2) Build the changes with "gradle build" and "gradle jar". 
3) replaced ~/.sdkman/candidates/grails/2.5.4/src/grails-datastore-gorm-3.1.5.RELEASE-sources.jar  with ~/../grails-data-mapping/grails-datastore-gorm/build/libs/grails-datastore-gorm-3.1.5.RELEASE-sources.jar because I assume all hibernate changes are bundled here
4) replaced ~/.sdkman/candidates/grails/2.5.4/lib/jars/org.grails/grails-datastore-gorm/grails-datastore-gorm-3.1.5.RELEASE.jar  with ~/../grails-data-mapping/grails-datastore-gorm/build/libs/grails-datastore-gorm-3.1.5.RELEASE-sources.jar because I assume all hibernate changes are bundled here

I am still seeing the same error (NullPointerException at at org.hibernate.engine.spi.BatchFetchQueue.removeBatchLoadableEntityKey(BatchFetchQueue.java:163)). I am not sure if the fix I back-fit was not the problem or if I am missing something in patching. Any help would be greatly appreciated.

Thank you,
John 

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/17ed5c1b-975d-46a9-b4d3-a006b942afd9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Trouble back-fitting fix to Grails 2.5

John Pandich
Thanks to a StackOverflow response by Hans Bogaards I remembered that many gorm jars are located in $HOME/.gradle/cache. The versions are much different than those generated by the Grails 2.5 gradle build. I believe they are aligned with gorm/hibernate releases. I may have open a can of worms on this back fit. 

--
You received this message because you are subscribed to the Google Groups "Grails Dev Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/grails-dev-discuss/c9b5eb95-8e62-4d15-84e3-15f48d14a08a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...